[PATCH] D98516: [WIP] Introduce the "implements" string attribute

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.
Herald added subscribers: hoy, ormris.
Herald added a project: All.


================
Comment at: llvm/lib/Passes/PassBuilder.cpp:283
+static cl::opt<bool> EnableImplementsAttrResolver(
+    "enable-implements-attr-resolver", cl::init(false), cl::Hidden,
+    cl::ZeroOrMore, cl::desc("Enable the implements attribute resolver"));
----------------
Omit `cl::init(false)`


================
Comment at: llvm/test/Transforms/ImplementsAttrResolver/intrinsic_implementation.ll:4
+
+ at llvm.compiler.used = appending global [2 x i8*] [i8* bitcast (float (float)* @my_sin to i8*), i8* bitcast (float (float)* @my_cos_type_mismatch to i8*)], section "llvm.metadata"
+
----------------
This test needs to be ported to `ptr` now:)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98516/new/

https://reviews.llvm.org/D98516