[PATCH] D158001: [lld][WebAssembly] Add support for -soname

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added a comment.

In D158001#4593256 <https://reviews.llvm.org/D158001#4593256>, @glandium wrote:

> FWIW, this patch breaks wasm2c, in the sense that it now generates different symbols for the same wasm linked with lld before and after this change, with no change in the link command line. Example: w2c_rlbox_0x5F_wasm_init_memory became w2c_0x24rlbox0x2Ewasm_0x5F_wasm_init_memory, and -soname doesn't make a difference.
> Edit: one can use wasm2c's -n option to avoid using the module name that is now always provided by lld.

I see, yes it sounds like `-n` is probably the best solution.

Separately, I do wonder if wasm2c should strip the file extension when it sees `rlbox.wasm` as the module name.   The `.wasm` part seem to translate to `0x2Ewasm` in the function names which doesn't seem like it adds anything useful.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158001/new/

https://reviews.llvm.org/D158001