[PATCH] D157061: [SampleProfile] Potential use after move in SampleProfileLoader::promoteMergeNotInlinedContextSamples

[Wenlei He via Phabricator via llvm-commits]

wenlei accepted this revision.
wenlei added a comment.
This revision is now accepted and ready to land.

thanks for the fix and following up with the comments, lgtm now.



================
Comment at: llvm/include/llvm/Transforms/Utils/SampleProfileLoaderBaseImpl.h:270
+  /// from the original profile as if they were top level sample profiles.
+  std::map<SampleContext, FunctionSamples> OutlineFunctionSamples;
+
----------------
Add a comment to explain why we use `std::map` here instead of existing `SampleProfileMap`, in case others stomped on this code later and tempted to change it to `SampleProfileMap` for consistency. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157061/new/

https://reviews.llvm.org/D157061