[PATCH] D157671: [DX] Add support for PSV signature elements

[Justin Bogner via Phabricator via llvm-commits]

bogner added inline comments.


================
Comment at: llvm/include/llvm/BinaryFormat/DXContainer.h:281
+};
+
+ArrayRef<EnumEntry<SemanticKind>> getSemanticKinds();
----------------
beanz wrote:
> bogner wrote:
> > Please undef `SEMANTIC_KIND` after the include here (and similarly below). That's generally a good practice and avoids leaking the define into a later include.
> I do the `#undef` in the header since I can't imagine a case where you'd include the `.def` file and not want to immediately undef the macro.
Makes sense. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157671/new/

https://reviews.llvm.org/D157671