[PATCH] D157500: [Thumb1] Use callee-saved register to adjust stack pointer

[Keith Walker via Phabricator via llvm-commits]

keith.walker.arm updated this revision to Diff 550778.
keith.walker.arm added a comment.

Amended on os the asserts to make the test now match what is being set as the scratch register.

I tried to come up with a suitable additional test which didn't involve the code actually saving R4 <https://reviews.llvm.org/source/lld/>.   I do have a C reproducer but it is quite a number of "fuzzed" c code and trying to turn it into a sensible IR/MIR regression test proved problematic.    Also I believe that we have sufficient tests in place to ensure that the scratch register we now used is one of the callee saved registers, thus the additional test is not really required.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157500/new/

https://reviews.llvm.org/D157500

Files:
  llvm/lib/Target/ARM/Thumb1FrameLowering.cpp
  llvm/test/CodeGen/ARM/cmse.ll
  llvm/test/CodeGen/ARM/thumb1-varalloc.ll
  llvm/test/CodeGen/Thumb/2011-EpilogueBug.ll
  llvm/test/CodeGen/Thumb/callee_save.ll
  llvm/test/CodeGen/Thumb/emergency-spill-slot.ll
  llvm/test/CodeGen/Thumb/frame-chain.ll
  llvm/test/CodeGen/Thumb/large-stack.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D157500.550778.patch
Type: text/x-patch
Size: 9888 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230816/85aaba52/attachment.bin>