[PATCH] D158058: [LV][VPlan] Refactor VPReductionRecipe to use reference for member RdxDesc

Mel Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 16 07:00:38 PDT 2023


Mel-Chen added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:1732
   /// Pointer to the TTI, needed to create the target reduction
   const TargetTransformInfo *TTI;
 
----------------
fhahn wrote:
> Should this also be reference?
Good question! I just verified, and it seems that `TTI` in `llvm::createTargetReduction` is not being used. Perhaps we can directly remove `TTI` from `VPReductionRecipe`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158058/new/

https://reviews.llvm.org/D158058



More information about the llvm-commits mailing list