[PATCH] D157733: [DAG] NFC: Add getScalarizeExtOrTrunc

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 16 05:31:20 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:1461-1462
+  SDValue DestOp;
+  if (Type == VT)
+    return Op;
+  auto Size = Op.getValueSizeInBits();
----------------
Redundant with check in getBitcast


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:1476-1477
+  SDValue DestOp;
+  if (Type == VT)
+    return Op;
+  auto Size = Op.getValueSizeInBits();
----------------
Redundant with check in getBitcast


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:1491-1492
+  SDValue DestOp;
+  if (Type == VT)
+    return Op;
+  auto Size = Op.getValueSizeInBits();
----------------
Redundant with check in getBitcast


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157733/new/

https://reviews.llvm.org/D157733



More information about the llvm-commits mailing list