[PATCH] D158068: [DAG] FoldSetCC - add missing icmp(X,undef) -> isTrueWhenEqual case

Yashwant Singh via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 16 04:40:42 PDT 2023


yassingh added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/swdev373493.ll:57
 bb:
   switch i32 undef, label %bb9 [
     i32 3, label %bb8
----------------
RKSimon wrote:
> nikic wrote:
> > Don't switch on undef...
> @yassingh This was added at D141895 - can this be replaced with the switch i32 %arg?
This came up in that review too. The test in question was generated by a lot of automatic reductions over a larger failure, I couldn't get rid of undef then either. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158068/new/

https://reviews.llvm.org/D158068



More information about the llvm-commits mailing list