[PATCH] D158058: [LV][VPlan] Refactor VPReductionRecipe to use reference for member RdxDesc

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 16 03:20:36 PDT 2023


fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!

It looks like there are some clang-format errors according to the precommit tests, please make sure to run clang-format-diff before landing.



================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:1732
   /// Pointer to the TTI, needed to create the target reduction
   const TargetTransformInfo *TTI;
 
----------------
Should this also be reference?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158058/new/

https://reviews.llvm.org/D158058



More information about the llvm-commits mailing list