[PATCH] D157979: [MSSAU] Clarify that the defining access does not matter

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 16 00:05:28 PDT 2023


nikic marked an inline comment as done.
nikic added a comment.

> Another alternative is creating a createMemoryAccess API which does not take the defining access, but likely not worth it.

We may be able to remove the Definition argument from these APIs entirely. I believe the only caller that supplies Definition now is https://github.com/llvm/llvm-project/blob/9d2f8ecac88c73242c99e7b353ac985fc57f1ed3/llvm/lib/Transforms/Scalar/SimpleLoopUnswitch.cpp#L323-L325, so we would only need an alternative for that one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157979/new/

https://reviews.llvm.org/D157979



More information about the llvm-commits mailing list