[PATCH] D157475: [GlobalISel] introduce MIFlag::NoConvergent

[Sameer Sahasrabuddhe via Phabricator via llvm-commits]

sameerds marked 3 inline comments as done.
sameerds added inline comments.


================
Comment at: llvm/test/CodeGen/MIR/AMDGPU/noconvergent.mir:29
+    %2:sreg_32 = IMPLICIT_DEF
+    %3:sreg_32 = noconvergent S_ADD_I32 %2, 1, implicit-def $scc
+...
----------------
arsenm wrote:
> Arguably the verifier should reject this 
Yeah, I had thought of silently dropping noconvergent when it is not relevant. But complaining loudly in the machine verifier is a much better idea. Implemented, with test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157475/new/

https://reviews.llvm.org/D157475