[PATCH] D157986: [Cmake] Make sure MSVC knows LLVM source files are UTF-8 encoded

Corentin Jabot via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 15 23:59:38 PDT 2023


cor3ntin added a comment.

This did the trick, however it's a bigger change than what i was hoping to get away with.

I think the path forward word be to make sure the test binaries, which do have a bunch of UTF string literals used at compile times are compiled with `/exec-charset:utf-8`.
My guess is that clangd tests currently _happen-to-work_ despite the sources of the test not being utf-encoded because as long as execution and source encoding match some bytes end up in the binaries which are equal to themselves.

So I need to figure out how to change the flags of the tests specifically.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157986/new/

https://reviews.llvm.org/D157986



More information about the llvm-commits mailing list