[PATCH] D157965: [RISCV][NFC] Move tests of inline asm memory constraints to separate file

Tue Aug 15 22:37:07 PDT 2023

wangpc added a comment.

In D157965#4590759 <https://reviews.llvm.org/D157965#4590759>, @jrtc27 wrote:

> In D157965#4590718 <https://reviews.llvm.org/D157965#4590718>, @wangpc wrote:
>
>> In D157965#4588623 <https://reviews.llvm.org/D157965#4588623>, @jrtc27 wrote:
>>
>>> Why do they need moving?
>>
>> We don't need to check `medium` code model for other constraints in `inline-asm.ll`, so I just move all memory-related constraints to new file.
>
> constraint_r(_zero) still do loads though.

The inline asm with constraint r won't influenced by code model because it will always be a register.

> And if you use --check-prefixes smartly then it only duplicates CHECK lines for functions that differ between code models.

Yeah I know. I just think that we should spilt them out as there are some custom lowering in `SelectInlineAsmMemoryOperand` for memory constraints, which is different from other constraints.
I don't think this will increase complexity as there are other separate test for constraints like `f`, `S`, etc.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157965/new/

https://reviews.llvm.org/D157965