[PATCH] D157965: [RISCV][NFC] Move tests of inline asm memory constraints to separate file

Tue Aug 15 20:31:12 PDT 2023

wangpc marked an inline comment as done.
wangpc added a comment.

In D157965#4588623 <https://reviews.llvm.org/D157965#4588623>, @jrtc27 wrote:

> Why do they need moving?

We don't need to check `medium` code model for other constraints in `inline-asm.ll`, so I just move all memory-related constraints to new file.

================
Comment at: llvm/test/CodeGen/RISCV/inline-asm-mem-constraint.ll:6
+; RUN:   | FileCheck -check-prefixes=RV64I %s
+; RUN: llc -mtriple=riscv32 -relocation-model=pic -verify-machineinstrs -no-integrated-as < %s \
+; RUN:   | FileCheck -check-prefixes=RV32I-PIC %s
----------------
jrtc27 wrote:
> And I said medany, not pic. PIC implies GOT indirection, which means the %pcrel_lo12 is hidden behind a load, and so isn't of interest.
Ooops, my mistake. Updated.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157965/new/

https://reviews.llvm.org/D157965