[PATCH] D158001: [lld][WebAssembly] Add support for -soname
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 15 17:27:48 PDT 2023
sbc100 added a comment.
In D158001#4590476 <https://reviews.llvm.org/D158001#4590476>, @dschuff wrote:
> Do we really want to always write a module name even if the output is not a DSO?
In general, yes I think this is useful feature. Especially in cases where the original filename might otherwise be lost to the runtime (e.g.. when using `WebAssembly.instantiate` rather than `WebAssembly.instantiateStreaming`)
> For DSOs it makes sense since they would usually have symbols and names, but for final linked modules it seems to me that we should write one if there are any other debug names in the module, but maybe not otherwise. I don't know why someone would want a module name if it were the only name in the binary?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158001/new/
https://reviews.llvm.org/D158001
More information about the llvm-commits
mailing list