[PATCH] D157671: [DX] Add support for PSV signature elements

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 15 17:09:01 PDT 2023


MaskRay added inline comments.


================
Comment at: llvm/lib/MC/DXContainerPSVInfo.cpp:40
+                   ArrayRef<PSVSignatureElement> Elements) {
+  for (auto El : Elements) {
+    // Put the name in the string table and the name list.
----------------
`const auto &`? `PSVSignatureElement` is large.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157671/new/

https://reviews.llvm.org/D157671



More information about the llvm-commits mailing list