[PATCH] D156101: [AMDGPU] Introduce real and keep fake True16 instructions.

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 15 17:02:35 PDT 2023


rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPU.td:1659-1661
+def UseRealTrue16Insts : Predicate<"Subtarget->useRealTrue16Insts()">,
+  AssemblerPredicate<(all_of FeatureTrue16BitInsts, FeatureRealTrue16Insts)>;
+def UseFakeTrue16Insts : Predicate<"Subtarget->hasTrue16BitInsts() && "
----------------
arsenm wrote:
> Should get a comment here explaining "RealTrue" and "FakeTrue" are. I can forsee this overstaying its forseen lifetime...
"FakeTrue" is truly really hilarious.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156101/new/

https://reviews.llvm.org/D156101



More information about the llvm-commits mailing list