[PATCH] D158025: [lld][WebAssembly] Always include bss segments when `--emit-relocs` is used
Derek Schuff via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 15 16:58:40 PDT 2023
dschuff accepted this revision.
dschuff added inline comments.
This revision is now accepted and ready to land.
================
Comment at: lld/wasm/Writer.cpp:679
// instruction, then we can also avoid including the segments.
- if (config->memoryImport.has_value() && !allowed.count("bulk-memory"))
+ // Finally, if we are emitting relocation then may refer to locations within
+ // the bss segments, so those segments need to exist.
----------------
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158025/new/
https://reviews.llvm.org/D158025
More information about the llvm-commits
mailing list