[PATCH] D156006: [InstrProf] Emit warnings when correlating lightweight profiles

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.

LGTM ... this seems like a straightforward enough improvement.



================
Comment at: llvm/tools/llvm-profdata/llvm-profdata.cpp:3002
+               "profile from debug info"),
+      cl::init(5));
   cl::opt<bool> ShowCovered(
----------------
For these sorts of flags, 0 usually means unlimited, and it might be good to follow that pattern here. E.g. see `--error-limit` in LLD (and I'm pretty sure Clang works the same way).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156006/new/

https://reviews.llvm.org/D156006