[PATCH] D158018: [FunctionPropertiesAnalysis] Add operand type counts

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/lib/Analysis/FunctionPropertiesAnalysis.cpp:125
           else if (C->getType()->isFloatTy())
             FloatingPointConstantCount += Direction;
+          ConstantOperandCount += Direction;
----------------
Integer/FP constant count makes little sense. Make them "Operand" counts as well.


================
Comment at: llvm/lib/Analysis/FunctionPropertiesAnalysis.cpp:134
+        } else if (isa<Argument>(Operand)) {
+          ArgumentOperandCount += Direction;
         }
----------------
The above should probably be a macro + a few invocations, also below. Anyway.


================
Comment at: llvm/lib/Analysis/FunctionPropertiesAnalysis.cpp:135
+          ArgumentOperandCount += Direction;
         }
       }
----------------
Add a "UnknownOperandCount".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158018/new/

https://reviews.llvm.org/D158018