[PATCH] D151887: InstSimplify: Start cleaning up simplifyFCmpInst

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 15 13:52:30 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:4112-4113
+  // Handle fcmp with constant RHS.
+  // TODO: Use match with a specific FP value, so these work with vectors with
+  // undef lanes.
+  if (C) {
----------------
jcranmer-intel wrote:
> This TODO is effectively done with m_APFloatAllowUndef, right?
Kind of, it doesn't handle cases like mixed negative-but-not-splat vectors


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151887/new/

https://reviews.llvm.org/D151887



More information about the llvm-commits mailing list