[PATCH] D157671: [DX] Add support for PSV signature elements

[Justin Bogner via Phabricator via llvm-commits]

bogner accepted this revision.
bogner added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/include/llvm/BinaryFormat/DXContainer.h:281
+};
+
+ArrayRef<EnumEntry<SemanticKind>> getSemanticKinds();
----------------
Please undef `SEMANTIC_KIND` after the include here (and similarly below). That's generally a good practice and avoids leaking the define into a later include.


================
Comment at: llvm/include/llvm/MC/DXContainerPSVInfo.h:71
     for (auto &Res : Resources)
       Res.swapBytes();
   }
----------------
Probably not for this change, but it would be nice to clean up all of this swapBytes stuff to use the helpers in `llvm/Endian.h` instead


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157671/new/

https://reviews.llvm.org/D157671