[PATCH] D157828: [RISCV][GISel] Initial legalization support for G_LOAD and G_STORE.

[Nitin John Raj via Phabricator via llvm-commits]

nitinjohnraj added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/GlobalISel/legalizer/rv32/legalize-load.mir:6
+--- |
+  define i8 @load_i8(ptr %x) {
+    %a = load i8, ptr %x, align 1
----------------
Do we need the LLVM IR to specify the alignment here? Other RISCV legalizer tests don't have the LLVM IR, so I'm wondering if we can get rid of it.


================
Comment at: llvm/test/CodeGen/RISCV/GlobalISel/legalizer/rv32/legalize-load.mir:53
+---
+name:            load_i8
+alignment:       4
----------------
Perhaps we could use a test for i7? It tests that we can legalize loads for odd sizes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157828/new/

https://reviews.llvm.org/D157828