[PATCH] D158003: [lld-macho] Stricter Bitcode Symbol Resolution

[Kyungwoo Lee via Phabricator via llvm-commits]

kyulee created this revision.
Herald added subscribers: ormris, steven_wu, hiraditya.
Herald added projects: lld-macho, All.
Herald added a reviewer: lld-macho.
kyulee requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

LLD resolves symbols before performing LTO compilation, assuming that the symbols in question are resolved by the resulting object files from LTO. However, there is a scenario where the prevailing symbols might be resolved incorrectly due to specific assembly symbols not appearing in the symbol table of the bitcode. This patch deals with such a scenario by generating an error instead of silently allowing a mis-linkage.
If a prevailing symbol is resolved through post-loaded archives via LC linker options, a warning will now be issued.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D158003

Files:
  lld/MachO/InputFiles.cpp
  lld/MachO/InputFiles.h
  lld/MachO/LTO.cpp
  lld/MachO/SymbolTable.cpp
  lld/test/MachO/symbol-resolution-error.ll
  lld/test/MachO/symbol-resolution-warning.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D158003.550393.patch
Type: text/x-patch
Size: 9703 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230815/266ea626/attachment.bin>