[PATCH] D157938: Fix problem with SCC sort

Andy Kaylor via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 15 10:11:30 PDT 2023


andrew.w.kaylor added a comment.

In D157938#4587091 <https://reviews.llvm.org/D157938#4587091>, @arsenm wrote:

> lgtm but is a test possible?

I would guess that it is possible to write a test for this, but I don't know this code well enough to do it. When this code was added, llvm/test/Transforms/SampleProfile/profile-context-order.ll was updated to test it, but clearly that update to the test didn't depend on this comparison. Perhaps @hoy could suggest a test?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157938/new/

https://reviews.llvm.org/D157938



More information about the llvm-commits mailing list