[PATCH] D157110: llvm-cov: __cxx_global_var_init functions disrupt coverage

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 15 09:45:57 PDT 2023


MaskRay added a comment.

I just noticed this patch. This problem was known, see `// TODO: Unhandled` from 01899bb4e41178af6f4cf7b32833e661fe1e3322 <https://reviews.llvm.org/rG01899bb4e41178af6f4cf7b32833e661fe1e3322> (2020).

We do not implement the feature attributing a block from another file. I mitigated the problem in 406e81b79d26dae6838cc69d10a3e22635da09ef <https://reviews.llvm.org/rG406e81b79d26dae6838cc69d10a3e22635da09ef> (re-landed yesterday).
We do not need mitigation on the llvm-cov gcov side.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157110/new/

https://reviews.llvm.org/D157110



More information about the llvm-commits mailing list