[PATCH] D157950: [RISCV][GISel] Mark G_GLOBAL_VALUE as legal.
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 15 09:30:50 PDT 2023
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG6eb36aed86ea: [RISCV][GISel] Mark G_GLOBAL_VALUE as legal. (authored by craig.topper).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157950/new/
https://reviews.llvm.org/D157950
Files:
llvm/lib/Target/RISCV/GISel/RISCVLegalizerInfo.cpp
llvm/test/CodeGen/RISCV/GlobalISel/legalizer/rv32/legalize-global.mir
llvm/test/CodeGen/RISCV/GlobalISel/legalizer/rv64/legalize-global.mir
Index: llvm/test/CodeGen/RISCV/GlobalISel/legalizer/rv64/legalize-global.mir
===================================================================
--- /dev/null
+++ llvm/test/CodeGen/RISCV/GlobalISel/legalizer/rv64/legalize-global.mir
@@ -0,0 +1,33 @@
+# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
+# RUN: llc -mtriple=riscv64 -run-pass=legalizer %s -o - | FileCheck %s
+
+--- |
+ @var = global i32 0
+
+ define ptr @test_global() {
+ ret ptr @var
+ }
+
+...
+---
+name: test_global
+alignment: 4
+tracksRegLiveness: true
+registers:
+ - { id: 0, class: _ }
+frameInfo:
+ maxAlignment: 1
+machineFunctionInfo:
+ varArgsFrameIndex: 0
+ varArgsSaveSize: 0
+body: |
+ bb.1 (%ir-block.0):
+ ; CHECK-LABEL: name: test_global
+ ; CHECK: [[GV:%[0-9]+]]:_(p0) = G_GLOBAL_VALUE @var
+ ; CHECK-NEXT: $x10 = COPY [[GV]](p0)
+ ; CHECK-NEXT: PseudoRET implicit $x10
+ %0:_(p0) = G_GLOBAL_VALUE @var
+ $x10 = COPY %0(p0)
+ PseudoRET implicit $x10
+
+...
Index: llvm/test/CodeGen/RISCV/GlobalISel/legalizer/rv32/legalize-global.mir
===================================================================
--- /dev/null
+++ llvm/test/CodeGen/RISCV/GlobalISel/legalizer/rv32/legalize-global.mir
@@ -0,0 +1,33 @@
+# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
+# RUN: llc -mtriple=riscv32 -run-pass=legalizer %s -o - | FileCheck %s
+
+--- |
+ @var = global i32 0
+
+ define ptr @test_global() {
+ ret ptr @var
+ }
+
+...
+---
+name: test_global
+alignment: 4
+tracksRegLiveness: true
+registers:
+ - { id: 0, class: _ }
+frameInfo:
+ maxAlignment: 1
+machineFunctionInfo:
+ varArgsFrameIndex: 0
+ varArgsSaveSize: 0
+body: |
+ bb.1 (%ir-block.0):
+ ; CHECK-LABEL: name: test_global
+ ; CHECK: [[GV:%[0-9]+]]:_(p0) = G_GLOBAL_VALUE @var
+ ; CHECK-NEXT: $x10 = COPY [[GV]](p0)
+ ; CHECK-NEXT: PseudoRET implicit $x10
+ %0:_(p0) = G_GLOBAL_VALUE @var
+ $x10 = COPY %0(p0)
+ PseudoRET implicit $x10
+
+...
Index: llvm/lib/Target/RISCV/GISel/RISCVLegalizerInfo.cpp
===================================================================
--- llvm/lib/Target/RISCV/GISel/RISCVLegalizerInfo.cpp
+++ llvm/lib/Target/RISCV/GISel/RISCVLegalizerInfo.cpp
@@ -89,5 +89,8 @@
.widenScalarToNextPow2(0)
.clampScalar(0, XLenLLT, XLenLLT);
+ getActionDefinitionsBuilder(G_GLOBAL_VALUE)
+ .legalFor({p0});
+
getLegacyLegalizerInfo().computeTables();
}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D157950.550363.patch
Type: text/x-patch
Size: 2522 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230815/12ce87bf/attachment.bin>
More information about the llvm-commits
mailing list