[llvm] 88903fa - [RISCV][GISel] Make G_SELECT of pointers legal
Craig Topper via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 15 09:20:18 PDT 2023
Author: Craig Topper
Date: 2023-08-15T09:20:08-07:00
New Revision: 88903fac1ff766a4883082c28baa7b13d76786a2
URL: https://github.com/llvm/llvm-project/commit/88903fac1ff766a4883082c28baa7b13d76786a2
DIFF: https://github.com/llvm/llvm-project/commit/88903fac1ff766a4883082c28baa7b13d76786a2.diff
LOG: [RISCV][GISel] Make G_SELECT of pointers legal
Reviewed By: reames
Differential Revision: https://reviews.llvm.org/D157819
Added:
Modified:
llvm/lib/Target/RISCV/GISel/RISCVLegalizerInfo.cpp
llvm/test/CodeGen/RISCV/GlobalISel/legalizer/rv32/legalize-select.mir
llvm/test/CodeGen/RISCV/GlobalISel/legalizer/rv64/legalize-select.mir
Removed:
################################################################################
diff --git a/llvm/lib/Target/RISCV/GISel/RISCVLegalizerInfo.cpp b/llvm/lib/Target/RISCV/GISel/RISCVLegalizerInfo.cpp
index fc51a731ba2126..a6f1302daf9e56 100644
--- a/llvm/lib/Target/RISCV/GISel/RISCVLegalizerInfo.cpp
+++ b/llvm/lib/Target/RISCV/GISel/RISCVLegalizerInfo.cpp
@@ -75,7 +75,7 @@ RISCVLegalizerInfo::RISCVLegalizerInfo(const RISCVSubtarget &ST) {
.clampScalar(0, XLenLLT, XLenLLT);
getActionDefinitionsBuilder(G_SELECT)
- .legalFor({{XLenLLT, XLenLLT}})
+ .legalFor({{XLenLLT, XLenLLT}, {p0, XLenLLT}})
.widenScalarToNextPow2(0)
.clampScalar(0, XLenLLT, XLenLLT)
.clampScalar(1, XLenLLT, XLenLLT);
diff --git a/llvm/test/CodeGen/RISCV/GlobalISel/legalizer/rv32/legalize-select.mir b/llvm/test/CodeGen/RISCV/GlobalISel/legalizer/rv32/legalize-select.mir
index b2da9fddd04a8e..a85a32d1ddd2aa 100644
--- a/llvm/test/CodeGen/RISCV/GlobalISel/legalizer/rv32/legalize-select.mir
+++ b/llvm/test/CodeGen/RISCV/GlobalISel/legalizer/rv32/legalize-select.mir
@@ -199,3 +199,25 @@ body: |
PseudoRET implicit $x10, implicit $x11, implicit $x12
...
+---
+name: select_ptr
+body: |
+ bb.0.entry:
+ ; CHECK-LABEL: name: select_ptr
+ ; CHECK: [[COPY:%[0-9]+]]:_(p0) = COPY $x10
+ ; CHECK-NEXT: [[COPY1:%[0-9]+]]:_(p0) = COPY $x11
+ ; CHECK-NEXT: [[COPY2:%[0-9]+]]:_(s32) = COPY $x12
+ ; CHECK-NEXT: [[C:%[0-9]+]]:_(s32) = G_CONSTANT i32 1
+ ; CHECK-NEXT: [[AND:%[0-9]+]]:_(s32) = G_AND [[COPY2]], [[C]]
+ ; CHECK-NEXT: [[SELECT:%[0-9]+]]:_(p0) = G_SELECT [[AND]](s32), [[COPY]], [[COPY1]]
+ ; CHECK-NEXT: $x10 = COPY [[SELECT]](p0)
+ ; CHECK-NEXT: PseudoRET implicit $x10
+ %0:_(p0) = COPY $x10
+ %1:_(p0) = COPY $x11
+ %2:_(s32) = COPY $x12
+ %3:_(s1) = G_TRUNC %2(s32)
+ %4:_(p0) = G_SELECT %3(s1), %0(p0), %1(p0)
+ $x10 = COPY %4(p0)
+ PseudoRET implicit $x10
+
+...
diff --git a/llvm/test/CodeGen/RISCV/GlobalISel/legalizer/rv64/legalize-select.mir b/llvm/test/CodeGen/RISCV/GlobalISel/legalizer/rv64/legalize-select.mir
index c5f53df25e78c6..6a3e8b0b035d35 100644
--- a/llvm/test/CodeGen/RISCV/GlobalISel/legalizer/rv64/legalize-select.mir
+++ b/llvm/test/CodeGen/RISCV/GlobalISel/legalizer/rv64/legalize-select.mir
@@ -224,3 +224,25 @@ body: |
PseudoRET implicit $x10, implicit $x11, implicit $x12
...
+---
+name: select_ptr
+body: |
+ bb.0.entry:
+ ; CHECK-LABEL: name: select_ptr
+ ; CHECK: [[COPY:%[0-9]+]]:_(p0) = COPY $x10
+ ; CHECK-NEXT: [[COPY1:%[0-9]+]]:_(p0) = COPY $x11
+ ; CHECK-NEXT: [[COPY2:%[0-9]+]]:_(s64) = COPY $x12
+ ; CHECK-NEXT: [[C:%[0-9]+]]:_(s64) = G_CONSTANT i64 1
+ ; CHECK-NEXT: [[AND:%[0-9]+]]:_(s64) = G_AND [[COPY2]], [[C]]
+ ; CHECK-NEXT: [[SELECT:%[0-9]+]]:_(p0) = G_SELECT [[AND]](s64), [[COPY]], [[COPY1]]
+ ; CHECK-NEXT: $x10 = COPY [[SELECT]](p0)
+ ; CHECK-NEXT: PseudoRET implicit $x10
+ %0:_(p0) = COPY $x10
+ %1:_(p0) = COPY $x11
+ %2:_(s64) = COPY $x12
+ %3:_(s1) = G_TRUNC %2(s64)
+ %4:_(p0) = G_SELECT %3(s1), %0(p0), %1(p0)
+ $x10 = COPY %4(p0)
+ PseudoRET implicit $x10
+
+...
More information about the llvm-commits
mailing list