[PATCH] D156872: [MachineVerifier] Verify LiveIntervals for PHIs

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 15 08:50:20 PDT 2023


arsenm added a comment.

This probably fixes some of the issues I had getting llvm-reduce to always use LiveIntervals



================
Comment at: llvm/lib/CodeGen/MachineVerifier.cpp:2529
+          // For PHIs all lanes should be live
+          if (MI->isPHI() && (LiveInMask != MOMask)) {
+            report("Not all lanes of PHI source live at use", MO, MONum);
----------------
Don't need parentheses around compare


================
Comment at: llvm/test/CodeGen/AMDGPU/split-mbb-lis-subrange.mir:6-11
+--- |
+  define amdgpu_kernel void @split_critical_edge_subranges() {
+    entry:
+      ret void
+  }
+---
----------------
Don't need the IR section


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156872/new/

https://reviews.llvm.org/D156872



More information about the llvm-commits mailing list