[PATCH] D157986: [Cmake] Make sure MSVC knows LLVM source files are UTF-8 encoded
Aaron Ballman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 15 08:25:27 PDT 2023
aaron.ballman added a comment.
Before you land the changes: how would this impact test files that are intentionally not encoded in UTF-8 (assuming we have any to test our failure behavior)? I presume MSVC would load the files up fine and since MSVC isn't compiling them, there's not an issue. But does this option change source editor behavior? e.g., if someone opens the file up, will they get invalid UTF-8 displayed to them? Will saving the file automatically try to encode it as UTF-8?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157986/new/
https://reviews.llvm.org/D157986
More information about the llvm-commits
mailing list