[llvm] a1562bb - Restore the link to committing a change to Phab

[Aaron Ballman via llvm-commits]

Author: Aaron Ballman
Date: 2023-08-15T11:10:51-04:00
New Revision: a1562bbc63b49a70b39ba075d9a3332f50cea11d

URL: https://github.com/llvm/llvm-project/commit/a1562bbc63b49a70b39ba075d9a3332f50cea11d
DIFF: https://github.com/llvm/llvm-project/commit/a1562bbc63b49a70b39ba075d9a3332f50cea11d.diff

LOG: Restore the link to committing a change to Phab

677326999f270395ecaec026178fe7ed148a0068 changed the developer policy
but dropped a documentation link telling folks to add a link to the
Phabricator page where review occurred. This restores that link and
wording, thanks to post-review feedback for catching the regression.

Added: 
    

Modified: 
    llvm/docs/DeveloperPolicy.rst

Removed: 
    


################################################################################
diff  --git a/llvm/docs/DeveloperPolicy.rst b/llvm/docs/DeveloperPolicy.rst
index af36f7c39e63c4..33b9f397f83d15 100644
--- a/llvm/docs/DeveloperPolicy.rst
+++ b/llvm/docs/DeveloperPolicy.rst
@@ -355,8 +355,11 @@ Below are some guidelines about the format of the message itself:
   caused PR#".
 
 * It is acceptable to add metadata to the commit message to automate processes,
-  including for downstream consumers. If the patch fixes a bug in GitHub Issues,
-  we encourage adding a reference to the issue being closed, as described
+  including for downstream consumers. If the patch has been reviewed, add a
+  link to its review page, as shown
+  `here <https://www.llvm.org/docs/Phabricator.html#committing-a-change>`_. If
+  the patch fixes a bug in GitHub Issues, we encourage adding a reference to
+  the issue being closed, as described
   `here <https://llvm.org/docs/BugLifeCycle.html#resolving-closing-bugs>`_.
   Other kinds of metadata are also acceptable, including links to resources
   that are not available to the entire community. However, such links should