[PATCH] D157979: [MSSAU] Clarify that the defining access does not matter

[Alina Sbirlea via Phabricator via llvm-commits]

asbirlea accepted this revision.
asbirlea added a comment.
This revision is now accepted and ready to land.

LGTM.
Another alternative is creating a createMemoryAccess API which does not take the defining access, but likely not worth it.
I'm fairly certain we cannot keep the defining access when inserting Defs in the general case, in particular when needing to insert new Phis.



================
Comment at: llvm/lib/Transforms/Scalar/GVN.cpp:2018
 
         // This added store is to null, so it will never executed and we can
         // just use the LiveOnEntry def as defining access.
----------------
Update or remove comment.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157979/new/

https://reviews.llvm.org/D157979