[PATCH] D155579: [Windows] Avoid using FileIndex for unique IDs on network mounts

Tue Aug 15 05:52:35 PDT 2023

aganea added a comment.

In D155579#4587472 <https://reviews.llvm.org/D155579#4587472>, @mstorsjo wrote:

> In D155579#4510035 <https://reviews.llvm.org/D155579#4510035>, @thieta wrote:
>
>> In D155579#4509952 <https://reviews.llvm.org/D155579#4509952>, @mstorsjo wrote:
>>
>>> @thieta IIRC you had a usecase where you scan through large numbers of files with LLVM code somewhere. Are you able to take this for a spin to make sure it doesn't affect the performance of your usecase too much?
>>
>> Will do, but probably not some time real soon
>
> @thieta Do you have time to try this out in the near future? I'd like to at least know of any potential performance impact before landing this.

@mstorsjo I think a good test for you would be to run clang-scan-deps on a large CDB .json, multithreaded, and see if there’s a difference before/after patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155579/new/

https://reviews.llvm.org/D155579