[PATCH] D157230: [SPARC][IAS] Add SETX pseudoinstruction

Tue Aug 15 04:24:45 PDT 2023

barannikov88 accepted this revision.
barannikov88 added a comment.
This revision is now accepted and ready to land.

LGTM with one suggestion.

================
Comment at: llvm/lib/Target/Sparc/AsmParser/SparcAsmParser.cpp:664
+  if (IsImm && isUInt<32>(ImmValue))
+    return expandSET(Inst, IDLoc, Instructions);
+
----------------
It would be cleaner to inline the necessary pieces of expandSET here, probably combining with the other `if`. It would also avoid relying on the same order of operands of SET and SETX.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157230/new/

https://reviews.llvm.org/D157230