[PATCH] D157848: [PreISelIntrinsicLowering] Use TLI for correct function

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 15 03:44:24 PDT 2023


nikic added a comment.

In D157848#4585069 <https://reviews.llvm.org/D157848#4585069>, @arsenm wrote:

> I would assume looking up the subtarget per-use is worse for compile time?

Looking up the subtarget is cheap if it's already instantiated. Usually all functions have the same features, so there's just the single subtarget. But of course the intrinsics will have different (no) features and will instantiate a separate subtarget. And apparently subtarget instantiation is super expensive.

Doesn't really matter unless you're compiling tiny files, it's just how I happened to notice this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157848/new/

https://reviews.llvm.org/D157848



More information about the llvm-commits mailing list