[PATCH] D156611: [llvm-cov] Fix a bug about using `convert-for-testing` on multi-source object files

Yuhao Gu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 15 03:40:11 PDT 2023


AtomicGu added a comment.

In D156611#4587396 <https://reviews.llvm.org/D156611#4587396>, @dyung wrote:

> Hi @AtomicGu, we have some internal tests that use covmapping files that started failing after this change. I notice as part of your commit message you stated that you "update(d) existing .covmapping files". How exactly did you do that? I'm guessing that we just need to update our private test files to work with your new format, but not being familiar with this area at all, I'm not sure how to convert our "old" .covmapping file to the "new" format that is expected. Any tips?

I'm so sorry to hear about that. I updated those old .covmapping file by a special temporary modified version of `llvm-cov`. I will upload it at once for your ergency.

I thought this file format is private and shouldn't be used in any project outside LLVM, as it's not mentioned in any public document. Well, it turns out I was wrong. @gulfem @phosek Do you think we need to add a new option to `covert-for-testing` for potential others to update their .covmapping files?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156611/new/

https://reviews.llvm.org/D156611



More information about the llvm-commits mailing list