[PATCH] D157948: [NFC]Fix possibly deref nullptr
Kan Shengchen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 15 03:08:52 PDT 2023
skan added a comment.
In D157948#4587327 <https://reviews.llvm.org/D157948#4587327>, @XinWang10 wrote:
> In D157948#4587289 <https://reviews.llvm.org/D157948#4587289>, @skan wrote:
>
>> Is this a NFC change or a bug fix? If NFC, shouldn't we use assert?
>
> cast could use assert internally, I think it's same to explicit assert.
Then how about others?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157948/new/
https://reviews.llvm.org/D157948
More information about the llvm-commits
mailing list