[PATCH] D155579: [Windows] Avoid using FileIndex for unique IDs on network mounts

Tue Aug 15 00:38:14 PDT 2023

mstorsjo added a comment.

In D155579#4510035 <https://reviews.llvm.org/D155579#4510035>, @thieta wrote:

> In D155579#4509952 <https://reviews.llvm.org/D155579#4509952>, @mstorsjo wrote:
>
>> @thieta IIRC you had a usecase where you scan through large numbers of files with LLVM code somewhere. Are you able to take this for a spin to make sure it doesn't affect the performance of your usecase too much?
>
> Will do, but probably not some time real soon

@thieta Do you have time to try this out in the near future? I'd like to at least know of any potential performance impact before landing this.

(Ideally I'd like to have this in a release, but this is something that definitely should cook in git main for a month or two before considering including in a release. At that point we're probably close to the late 17.0.x, where it's probably too risky to include, so I guess this is practically 18.x material in any case?)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155579/new/

https://reviews.llvm.org/D155579