[PATCH] D156611: [llvm-cov] Fix a bug about using `convert-for-testing` on multi-source object files

Gulfem Savrun Yeniceri via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 14 19:42:50 PDT 2023


gulfem added a comment.

In D156611#4555830 <https://reviews.llvm.org/D156611#4555830>, @phosek wrote:

> This is a breaking change since it modifies the `.covmapping` format in a backwards incompatible way. For `.profdata` format we always try to avoid breaking changes and provide backwards compatibility, but I don't know if the same holds for the `.covmapping` format which is used only for testing. @davidxl do you have any thoughts on that?

I was going to suggest bumping the coverage mapping format version if there is a concern about backwards compatibility. But, I don't think this is really changing the coverage mapping format itself. To me, it fixes the issue where we convert objects files to `covmapping` files, and the way we read coverage via using object files should not be impacted by that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156611/new/

https://reviews.llvm.org/D156611



More information about the llvm-commits mailing list