[PATCH] D157451: [AMDGPU] Emit .actual_access metadata

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/CodeGen/AMDGPU/hsa-metadata-deduced-arg-attr.ll:12
+; CHECK:       - .args:
+; CHECK-NOT:       .actual_access:  read_only
+; CHECK-LABEL:   .name:          test_only_ro_arg
----------------
Reduce this down to the read_only, best to have -NOT checks as loose as possible if you aren't going to CHECK-NEXT everything


================
Comment at: llvm/test/CodeGen/AMDGPU/hsa-metadata-deduced-arg-attr.ll:26
+; CHECK:       - .args:
+; CHECK-NOT:       - .actual_access:  write_only
+; CHECK-LABEL:   .name:          test_only_wo_arg
----------------
Ditto


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157451/new/

https://reviews.llvm.org/D157451