[PATCH] D157061: [SampleProfile] Potential use after move in SampleProfileLoader::promoteMergeNotInlinedContextSamples

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 14 15:39:20 PDT 2023


wenlei added inline comments.


================
Comment at: llvm/include/llvm/ProfileData/SampleProfReader.h:533
+  /// instead of the original profiles to prevent potential rehashing.
+  SampleProfileMap OutlineFunctionSamples;
+
----------------
Can this be owned by SampleProfileLoader instead? Reader should just present what's being read out of an input profile, and should not couple with profile loader in other ways. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157061/new/

https://reviews.llvm.org/D157061



More information about the llvm-commits mailing list