[PATCH] D157836: [RFC][IR] Correct lowering of `f128` intrinsics

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

If there's literally no implementation of sinf128 available, I don't think we can do much better than just letting the linker produce a "sinf128 not found" error.  I mean, a compiler error might be slightly better, but not by a lot, so I don't think it's worth the complexity to try to produce one.  (And this way lets the user provide their own implementation if they want to.)

My primary concern here is the effect on non-x86 targets.  For targets where "long double" is f128, lowering "llvm.sin.f128" to "sinl" is fine, and messing with the name could break previously working code.  So maybe instead of messing with RuntimeLibcalls.def directly, we should make the backend fix the names (call setLibcallName() in X86ISelLowering.cpp).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157836/new/

https://reviews.llvm.org/D157836