[PATCH] D157079: [TableGen] Fix wrong lex result on 64-bit integer boundaries

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 14 12:49:09 PDT 2023


MaskRay added inline comments.


================
Comment at: llvm/test/TableGen/64-bit-int.td:21
+
+#ifdef VALID
+  bits<64> BinVal = 0x8000000000000000;
----------------
Positive tests don't need to be surrounded by `#ifdef VALID ... #endif`.

Only negative tests need a preprocessor guard.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157079/new/

https://reviews.llvm.org/D157079



More information about the llvm-commits mailing list