[PATCH] D157908: [BOLT][DWARF] Fix location list order

[Alexander Yermolovich via Phabricator via llvm-commits]

ayermolo created this revision.
Herald added subscribers: treapster, hoy, modimo, wenlei.
Herald added a reviewer: rafauler.
Herald added a reviewer: Amir.
Herald added a reviewer: maksfb.
Herald added a project: All.
ayermolo requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added subscribers: llvm-commits, jplehr, yota9, sstefan1.
Herald added a project: LLVM.

This bug crept in when CU partitionning was introduced. It manifests itself when
there are CUs that use location lists that come before CUs that are part of
thin-lto. BOLT processes CUs with cross CU references first (these are produced
by thin-lto). When we wrote out all the location lists we did it in original
order. Since DWARF4 uses offsets directly in to .debug_loc those offsets in DIEs
became wrong.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D157908

Files:
  bolt/lib/Rewrite/DWARFRewriter.cpp
  bolt/test/X86/Inputs/dwarf4-cross-cu-with-loclist.s
  bolt/test/X86/Inputs/dwarf4-two-entries-loclist.s
  bolt/test/X86/Inputs/dwarf5-loclist.s
  bolt/test/X86/dwarf4-cross-cu-loclist-dwarf4-loclist--dwarf5-loclist.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D157908.550040.patch
Type: text/x-patch
Size: 73528 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230814/f6560339/attachment.bin>