[PATCH] D157818: [RISCV][GISel] Legalize G_PHI and G_BRCOND.

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 14 09:25:31 PDT 2023


reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM w/minor comment



================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.cpp:905
     return true;
 
   // Handle a single unconditional branch.
----------------
Can you convert the I->isPreISelOpcode() check to an early return w/comment here?  (Since all of the cases following are guarded by this condition.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157818/new/

https://reviews.llvm.org/D157818



More information about the llvm-commits mailing list