[PATCH] D157826: [X86] Allow inlining callees missing VLX feature

[Kal Conley via Phabricator via llvm-commits]

kalcutter added inline comments.


================
Comment at: llvm/lib/Target/X86/X86TargetTransformInfo.cpp:6058
   // that may become ABI-incompatible as a result of inlining.
   if ((RealCallerBits & RealCalleeBits) != RealCalleeBits)
     return false;
----------------
Thinking about this more. Why shouldn't this function just end at this line? ISTM that only features should control if inlining is _possible_ or not. I don't see how checking for ABI compatibility between types is helpful. Once the callee gets inlined, it can take on the ABI of the caller anyway.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157826/new/

https://reviews.llvm.org/D157826