[PATCH] D157844: [llvm][CMake] Improve error message for unknown or experimental targets

[David Spickett via Phabricator via llvm-commits]

DavidSpickett marked 2 inline comments as done.
DavidSpickett added inline comments.


================
Comment at: llvm/CMakeLists.txt:935
+    else()
+      message(FATAL_ERROR "The target `${t}' is not a default target. It may be "
+        "experimental, if so it must be passed via "
----------------
beanz wrote:
> nit: I don’t really love the “default” target phrasing. We don’t really have a good way of distinguishing the “all but experimental” target list.
> 
> Two alternate suggestions:
> 1) We could call them “known” because they are targets known to the build system.
> 2) We could call them “core tier” which would borrow language from the community support policy (see: https://www.llvm.org/docs/SupportPolicy.html).
> 
> I slightly prefer option 2.
Agreed, let's use the pre-existing term.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157844/new/

https://reviews.llvm.org/D157844