[PATCH] D150144: cmake: add missing dependency on Attributes.inc

Mon Aug 14 08:17:55 PDT 2023

jroelofs added a comment.

In D150144#4583702 <https://reviews.llvm.org/D150144#4583702>, @chapuni wrote:

> @jroelofs Sorry for the delay and thanks for the report.
>
> I didn't expect the case of `LLVM_TABLEGEN=$BUILD/bin/llvm-tblgen` (with path). It would be bad if `llvm-min-tblgen` is overridden by `LLVM_TABLEGEN`, that is not an external executable but is built in-tree.
>
> I would like the config not to specify `LLVM_TABLEGEN` unless it is external. But I could let CMake check whether `LLVM_TABLEGEN` points actually internal target.

I think the fact that I've pointed it at an internal target is a red herring. This issue shows up whether it points at an internal one, or an externally-provided one.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150144/new/

https://reviews.llvm.org/D150144