[PATCH] D157881: [DWARFVerifier] Fix getNames return type mismatch

Felipe de Azevedo Piovezan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 14 08:00:38 PDT 2023


fdeazeve created this revision.
Herald added a subscriber: hiraditya.
Herald added a project: All.
fdeazeve requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

D155723 <https://reviews.llvm.org/D155723> changed the return type of getNames to a SmallVector of a different
size. However, it failed to also update the declaration of the variable that is
returned in such function.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D157881

Files:
  llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp


Index: llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp
===================================================================
--- llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp
+++ llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp
@@ -1354,7 +1354,7 @@
 static SmallVector<StringRef, 3> getNames(const DWARFDie &DIE,
                                           bool IncludeStrippedTemplateNames,
                                           bool IncludeLinkageName = true) {
-  SmallVector<StringRef, 2> Result;
+  SmallVector<StringRef, 3> Result;
   if (const char *Str = DIE.getShortName()) {
     Result.emplace_back(Str);
     if (IncludeStrippedTemplateNames) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D157881.549941.patch
Type: text/x-patch
Size: 646 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230814/d53698af/attachment.bin>


More information about the llvm-commits mailing list