[PATCH] D157839: [RISCV] Support global address as inline asm memory operand of `m`

Mon Aug 14 06:59:58 PDT 2023

asb accepted this revision.
asb added a comment.
This revision is now accepted and ready to land.

LGTM, though I'd appreciate an extra pair of eyes that there aren't other lurking problems that have been missed.

Could you please expand the test cases a bit? It seems worth testing e.g.

  @ga1 = dso_local global [4000 x i32] zeroinitializer, align 4
  ...
    call void asm "sw zero, $0", "=*m"(ptr nonnull elementtype(i32) getelementptr inbounds ([400000 x i32], ptr @ga1, i32 0, i32 2000))

and likely a variant with a smaller offset too. Both seem to generate reasonable output to my eye.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157839/new/

https://reviews.llvm.org/D157839